Fix HTTP headers when downloading files #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
headers-for-downloaded-files
branch
from
f6c039b to
de8f047
Compare
zackgalbreath
requested changes
Feb 14, 2024
Contributor
zackgalbreath
left a comment
zackgalbreath
left a comment
There was a problem hiding this comment.
I think this suggested change will fix the failing test in CI
Co-authored-by: Zack Galbreath <zack.galbreath@kitware.com>
zackgalbreath
approved these changes
Feb 14, 2024
Collaborator
Author
|
Merging manually due to open.cdash.org slowness... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1796 introduced the usage of Laravel's
Storage::download()helper, which forced the browser to download all files by default. This change was inconvenient for many users who wanted to view simple text files.This PR modifies the HTTP headers such that text files will be opened in the browser, and binary files will be downloaded in all major browsers. By setting the content-type to
text/plain, the possibility of XSS attacks is mitigated.