Store BuildInformation using upsert instead of updateOrCreate #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
force-pushed
the
update_buildinfo_transaction
branch
from
9ea54ba to
0d0a33c
Compare
updateOrCreate is apparently not atomic laravel/framework#19372 ...but upsert is??? https://stackoverflow.com/a/70978095 https://stackoverflow.com/a/70209143
zackgalbreath
force-pushed
the
update_buildinfo_transaction
branch
from
0d0a33c to
65c03ec
Compare
zackgalbreath
changed the title
Contributor
Author
|
@williamjallen this seems to have done the trick. I haven't seen any |
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Is the transaction necessary now that you're using upsert?
williamjallen
approved these changes
Mar 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Collaborator
|
Delay appears to be due to a CircleCI issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateOrCreate is apparently not atomic
laravel/framework#19372
...but upsert is???
https://stackoverflow.com/a/70978095
https://stackoverflow.com/a/70209143