Improve /projects load performance#2454
Merged
josephsnyder merged 1 commit intoKitware:masterfrom Sep 24, 2024
Merged
Conversation
josephsnyder
approved these changes
Sep 24, 2024
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
With a small number of projects, the buildCount field appears and is respected by the /projects page. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/projectscurrently shows a loading indicator briefly on large production instances with many builds. This PR attempts to address the issue by adding abuildCountfield to the Project type in the GraphQL API, which allows filtered count queries to be executed more efficiently. I plan to add similar fields for build errors/warnings, tests, etc in the future.