Create storage dirs before enabling maintenance mode#2459
Merged
williamjallen merged 1 commit intoKitware:masterfrom Sep 24, 2024
Merged
Create storage dirs before enabling maintenance mode#2459williamjallen merged 1 commit intoKitware:masterfrom
williamjallen merged 1 commit intoKitware:masterfrom
Conversation
zackgalbreath
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel's maintenance mode writes a file to the storage directory, which is problematic for new instances which do not have storage directories created yet. This PR moves the directory creation logic before the command to turn on maintenance mode, which allows new instances to be spun up seamlessly without needing commands to be run manually.