Make submission parsing atomic#3557
Merged
williamjallen merged 1 commit intoKitware:masterfrom Mar 30, 2026
Merged
Conversation
Collaborator
Author
|
Depends on #3556. I will rebase this once that PR is merged. |
josephsnyder
approved these changes
Mar 30, 2026
This commit wraps the business logic of the submission processing system in a transaction. In addition to the obvious benefit of submissions now being saved atomically, the total number of transactions which must be committed is reduced, at the cost of transactions being open longer. In theory, this should result in better Postgres performance for IO-bound CDash instances.
williamjallen
force-pushed
the
submission-transactions
branch
from
5841fac to
28d8c54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit wraps the business logic of the submission processing system in a transaction. In addition to the obvious benefit of submissions now being saved atomically, the total number of transactions which must be committed is reduced, at the cost of transactions being open longer. In theory, this should result in better Postgres performance for IO-bound CDash instances.