Skip to content

Add handling for branch coverage information from CTest#3598

Merged
williamjallen merged 1 commit into
Kitware:masterfrom
josephsnyder:add_ctest_branch_coverage_handling
Apr 10, 2026
Merged

Add handling for branch coverage information from CTest#3598
williamjallen merged 1 commit into
Kitware:masterfrom
josephsnyder:add_ctest_branch_coverage_handling

Conversation

@josephsnyder
Copy link
Copy Markdown
Member

When reading the coverage log file, look for incoming "BranchesTested" and "BranchesUntested" attributes on each log line. If either is greater than 0, add a branch entry to that line.

Comment thread tests/Feature/Submission/Tests/CoverageLogXMLTest.php Outdated
@williamjallen williamjallen marked this pull request as draft April 8, 2026 15:33
@josephsnyder josephsnyder force-pushed the add_ctest_branch_coverage_handling branch 2 times, most recently from da1a747 to 4cf01c7 Compare April 9, 2026 15:37
@josephsnyder josephsnyder marked this pull request as ready for review April 9, 2026 15:37
@josephsnyder josephsnyder marked this pull request as draft April 9, 2026 16:29
@josephsnyder
Copy link
Copy Markdown
Member Author

Converting back to draft. The coverage display of a real submission only showed the branch information

@josephsnyder josephsnyder force-pushed the add_ctest_branch_coverage_handling branch from 4cf01c7 to c8dbdf6 Compare April 9, 2026 18:31
@josephsnyder josephsnyder marked this pull request as ready for review April 9, 2026 19:38
Comment thread app/Http/Submission/Handlers/CoverageLogHandler.php Outdated
Comment thread app/Http/Submission/Handlers/CoverageLogHandler.php Outdated
Comment thread app/Http/Submission/Handlers/CoverageLogHandler.php Outdated
Comment thread tests/Feature/Submission/Tests/data/with_LogBranchCoverage.xml
Comment thread tests/Feature/Submission/Tests/CoverageLogXMLTest.php
@josephsnyder josephsnyder force-pushed the add_ctest_branch_coverage_handling branch from c8dbdf6 to 4445cbd Compare April 10, 2026 12:24
Copy link
Copy Markdown
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple stylistic things to fix and then this should be good to go.

Comment thread app/Http/Submission/Handlers/CoverageLogHandler.php Outdated
Comment thread app/Http/Submission/Handlers/CoverageLogHandler.php Outdated
When reading the coverage log file, look for incoming "BranchesTested"
and "BranchesUntested" attributes on each log line.  If either is greater
than 0, add a branch entry to that line.
@josephsnyder josephsnyder force-pushed the add_ctest_branch_coverage_handling branch from 4445cbd to 9567114 Compare April 10, 2026 14:11
@williamjallen williamjallen added this pull request to the merge queue Apr 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 10, 2026
@williamjallen williamjallen added this pull request to the merge queue Apr 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 10, 2026
@williamjallen williamjallen added this pull request to the merge queue Apr 10, 2026
Merged via the queue into Kitware:master with commit f65d784 Apr 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants