Skip to content

Remove deprecated GraphQL fields #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamjallen merged 1 commit into from
Apr 6, 2026
Merged

Remove deprecated GraphQL fields #3602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/GraphQL/Validators/CreateProjectInputValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ public function rules(): array
Rule::unique(Project::class, 'name'),
new ProjectNameRule(),
],
'homeurl' => [
'prohibits:homeUrl',
],
'homeUrl' => [
'prohibits:homeurl',
],
'visibility' => [
new ProjectVisibilityRule(),
],
Expand Down
28 changes: 0 additions & 28 deletions graphql/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ type Project {
"Description."
description: String

"Homepage for this project."
homeurl: Url @deprecated(reason: "Use 'homeUrl' instead.")

"Homepage for this project."
homeUrl: Url @rename(attribute: "homeurl")

Expand Down Expand Up @@ -402,20 +399,11 @@ input CreateProjectInput @validator {
"Description."
description: String

"Project homepage"
homeurl: Url @deprecated(reason: "Use 'homeUrl' instead.")

"Project homepage"
homeUrl: Url @rename(attribute: "homeurl") @deprecated(reason: "This field will be removed in the next major version of CDash.")

"Visibility."
visibility: ProjectVisibility! @rename(attribute: "public")

"A boolean indicating whether authenticated submissions are required."
authenticateSubmissions: Boolean! @rename(attribute: "authenticatesubmissions")

"A LDAP group users must be a member of to access the project."
ldapFilter: String @deprecated(reason: "This field will be removed in the next major version of CDash.") @rename(attribute: "ldapfilter")
}


Expand Down Expand Up @@ -846,18 +834,6 @@ type Build {
filters: _ @filter
): [BuildError!]! @hasMany(type: CONNECTION) @orderBy(column: "id", direction: DESC)

# TODO: Make an "errors" field which returns the union of basic and rich errors
"""
A list of "basic" errors submitted for this build.
"""
basicErrors: [BasicBuildAlert!]! @hasMany(type: CONNECTION) @orderBy(column: "id", direction: DESC) @deprecated(reason: "This field will be removed in the next major version of CDash. Use buildErrors instead.")

# TODO: Make a "warnings" field which returns the union of basic and rich warnings
"""
A list of "basic" warnings submitted for this build.
"""
basicWarnings: [BasicBuildAlert!]! @hasMany(type: CONNECTION) @orderBy(column: "id", direction: DESC) @deprecated(reason: "This field will be removed in the next major version of CDash. Use buildErrors instead.")

project: Project! @belongsTo

notes: [Note!]! @belongsToMany(type: CONNECTION) @orderBy(column: "id", direction: DESC)
Expand All @@ -882,10 +858,6 @@ type Build {
filters: _ @filter
): [Build!]! @hasMany(type: CONNECTION) @orderBy(column: "id")

coverageResults(
filters: _ @filter
): [Coverage!]! @belongsToMany(type: CONNECTION, relation: "coverage") @orderBy(column: "id", direction: DESC) @deprecated(reason: "Use 'coverage' instead.")

coverage(
filters: _ @filter
): [Coverage!]! @belongsToMany(type: CONNECTION) @orderBy(column: "id", direction: DESC)
Expand Down
9 changes: 0 additions & 9 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26595,15 +26595,6 @@ parameters:
count: 4
path: tests/Feature/GlobalInvitationAcceptanceTest.php

-
rawMessage: '''
Call to deprecated method basicAlerts() of class App\Models\Build:
02/09/2026 Use buildErrors() instead
'''
identifier: method.deprecated
count: 4
path: tests/Feature/GraphQL/BuildTypeTest.php

-
rawMessage: '''
Call to deprecated method coverageResults() of class App\Models\Build:
Expand Down
Loading