Fix flaky expected build test#3622
Merged
williamjallen merged 1 commit intoKitware:masterfrom Apr 8, 2026
Merged
Conversation
The expected build test has become extremely flaky recently due to unrelated test scheduling changes. The original source of the flakiness is Kitware#3366. This PR attempts to improve the robustness of this test by adding a hack to ensure that the page has reloaded properly before moving on from actions which call `window.reload()`.
josephsnyder
approved these changes
Apr 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
The expected build test has become extremely flaky recently due to unrelated test scheduling changes. The original source of the flakiness is #3366. This PR attempts to improve the robustness of this test by adding a hack to ensure that the page has reloaded properly before moving on from actions which call `window.reload()`.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected build test has become extremely flaky recently due to unrelated test scheduling changes. The original source of the flakiness is #3366. This PR attempts to improve the robustness of this test by adding a hack to ensure that the page has reloaded properly before moving on from actions which call
window.reload().