Add support for build error links when project not repo root#3633
Merged
Conversation
Not all projects have the root of their CMake project at the root of the repository. CDash currently assumes the project is at the top level of the repository, meaning that all build error links are broken for projects where this is not the case. This PR adds the ability to specify the repository-relative path to the top-level CMakeLists.txt.
josephsnyder
approved these changes
Apr 10, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Looks good for this page! It might be worth expanding this to the Update links as well, even though theres a lot of work ahead for that page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all projects have the root of their CMake project at the root of the repository. CDash currently assumes the project is at the top level of the repository, meaning that all build error links are broken for projects where this is not the case. This PR adds the ability to specify the repository-relative path to the top-level CMakeLists.txt.