Revamp build update page#3635
Merged
williamjallen merged 1 commit intoKitware:masterfrom Apr 13, 2026
Merged
Conversation
josephsnyder
approved these changes
Apr 13, 2026
Member
There was a problem hiding this comment.
It looks great, exactly like we hashed out. My one nitpick, which is not a blocker, is that the leaf nodes of the file tree seem to be interactable. The highlighting implies a click or some interaction would link you somewhere.
Is it possible to make those not react to mouse events?
Collaborator
Author
Unfortunately not, assuming we don't want them to look disabled. In the future, I'm hoping to turn them into links to the exact file in the diff, but that requires some work outside the scope of this PR. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overhauls the build update page, completely redesigning the UI while switching the underlying data source to GraphQL. Another improvement is the addition of browser tests for this page, which was previously untested. Along the way, I fixed the comparison links reported broken in #3625. Closes #3625.