Factor out reusable flame graph component#3676
Merged
Merged
Conversation
The flame graph component used to display build instrumentation data can be reused to display a flame graph of tests using the test start time added in Kitware#3450. This PR factors our a common component which can be shared between these two use cases. In addition, I organized all of the shared chart components into a common directory in anticipation of further improvements.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flame graph component used to display build instrumentation data can be reused to display a flame graph of tests using the test start time added in #3450. This PR factors our a common component which can be shared between these two use cases. In addition, I organized all of the shared chart components into a common directory in anticipation of further improvements.