Skip to content

Fix slider issues #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jourdain merged 3 commits into from
Apr 16, 2026
+27 −19
Merged

Fix slider issues #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82038de
fix: prevent animation toolbar crash when no data is loaded
berkgeveci Apr 16, 2026
7ff4445
fix: correct typo amimation_step_max to animation_step_max
berkgeveci Apr 16, 2026
bea45ed
feat: support dimensions without coordinate variables
berkgeveci Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/e3sm_quickview/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,20 +442,26 @@ async def data_loading_open(self, simulation, connectivity):
# Update Layer/Time values and ui layout
n_cols = 0
available_tracks = []
dim_units = {}
for name, dim in self.source.dimensions.items():
values = dim.data
# Convert to list for JSON serialization
self.state[name] = (
values.tolist()
if hasattr(values, "tolist")
else list(values)
if values is not None
else []
)
if values is not None:
self.state[name] = (
values.tolist()
if hasattr(values, "tolist")
else list(values)
)
else:
self.state[name] = list(range(dim.size))

if values is not None and len(values) > 1:
if dim.size > 1:
n_cols += 1
available_tracks.append(name)
if dim.units:
dim_units[name] = dim.units

self.state.dim_units = dim_units
self.state.toolbar_slider_cols = 12 / n_cols if n_cols else 12
self.state.animation_tracks = available_tracks
self.state.animation_track = (
Expand Down
24 changes: 13 additions & 11 deletions src/e3sm_quickview/components/toolbars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def __init__(self):
)
v3.VSpacer()
v3.VLabel(
"{{ t_values ? parseFloat(t_values[t_idx]).toFixed(2) : '' }} hPa (k={{ t_idx }})",
"{{ dim_units[track] ? parseFloat(t_values[t_idx]).toFixed(2) + ' ' + dim_units[track] : 'Index value: ' + t_idx }} (k={{ t_idx }})",
classes="text-body-2",
)
v3.VSlider(
Expand Down Expand Up @@ -418,7 +418,7 @@ def __init__(self):
classes="text-subtitle-2 ml-2 mt-1",
)
v3.VLabel(
"{{ t_values ? parseFloat(t_values[Number(t_idx)]).toFixed(2) : '' }} hPa",
"{{ dim_units[track] ? parseFloat(t_values[Number(t_idx)]).toFixed(2) + ' ' + dim_units[track] : 'Index value: ' + t_idx }}",
classes="text-body-2 text-no-wrap ml-2 mt-1",
)

Expand All @@ -438,7 +438,7 @@ def __init__(self):
)
with v3.VRow(classes="ma-0 px-2 align-center"):
v3.VSelect(
v_model=("animation_track", "timestamps"),
v_model=("animation_track", None),
items=("available_animation_tracks", []),
flat=True,
variant="plain",
Expand All @@ -450,7 +450,7 @@ def __init__(self):
v3.VSlider(
v_model=("animation_step", 1),
min=0,
max=("amimation_step_max", 0),
max=("animation_step_max", 0),
step=1,
hide_details=True,
density="compact",
Expand All @@ -472,14 +472,14 @@ def __init__(self):
v3.VIconBtn(
icon="mdi-chevron-right",
flat=True,
disabled=("animation_step === amimation_step_max",),
click="animation_step = Math.min(amimation_step_max, animation_step + 1)",
disabled=("animation_step === animation_step_max",),
click="animation_step = Math.min(animation_step_max, animation_step + 1)",
)
v3.VIconBtn(
icon="mdi-page-last",
disabled=("animation_step === amimation_step_max",),
disabled=("animation_step === animation_step_max",),
flat=True,
click="animation_step = amimation_step_max",
click="animation_step = animation_step_max",
)
v3.VDivider(vertical=True, classes="mx-2")
v3.VIconBtn(
Expand All @@ -491,10 +491,12 @@ def __init__(self):
@change("animation_track")
def _on_animation_track_change(self, animation_track, **_):
self.state.animation_step = 0
self.state.amimation_step_max = 0
self.state.animation_step_max = 0

if animation_track:
self.state.amimation_step_max = len(self.state[animation_track]) - 1
values = self.state[animation_track]
if values:
self.state.animation_step_max = len(values) - 1

@change("animation_step")
def _on_animation_step(self, animation_track, animation_step, **_):
Expand All @@ -510,7 +512,7 @@ async def _run_animation(self):
with self.state as s:
while s.animation_play:
await asyncio.sleep(0.1)
if s.animation_step < s.amimation_step_max:
if s.animation_step < s.animation_step_max:
with s:
s.animation_step += 1
await self.server.network_completion
Expand Down
Loading