Fix aspect ratio slider: invert direction, allow shorter views#69
Merged
jourdain merged 1 commit intoKitware:masterfrom Apr 29, 2026
Merged
Fix aspect ratio slider: invert direction, allow shorter views#69jourdain merged 1 commit intoKitware:masterfrom
jourdain merged 1 commit intoKitware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix aspect ratio slider: invert direction, allow shorter views
Default
Shorter
Taller
Note: This is a breaking change for previous saved state files. Simplest Fix: Just let it load as-is. If someone loads an old state file with aspect_ratio: 2, under the new scheme that means very tall (CSS ratio 0.5). Previously it meant very wide (CSS ratio 2). The visual will differ, but the they can just adjust the slider. I feel this is acceptable for a layout preference. True Fix: The ranges overlap at [1, 2], so there's no way to distinguish an old state value of 1.5 from a new state value of 1.5. The only clean fix would be renaming the state variable (e.g. view_height_ratio) or adding a version field to the state file, which I thought would be over engineering compared to adjusting one slider.
closes #61