Conversation
Also fixes up overloaded term "bounds". Bounds now refers to world bounds, and extent is the image-space bounds of the image.
This is a useful transform to have in the image config.
applyViewAnnotations makes much more sense.
Instead of transforming objects into image space, just transform the camera to look at slices correctly. The views no longer look along fixed world axes. Instead, they are labeled as Axial, Sagittal, or Coronal, and the direction in which they look is solely determined by the dataset orientation. In fact, the views look along each dataset's IJK axis, effectively operating as an orthogonal MPR view. This should provide a more consistent view when looking at different datasets.
Picking the width and height of the resize-to-fit rectangle depends on both the looking axis and the view up axis.
timthirion
reviewed
Mar 9, 2021
Contributor
timthirion
left a comment
timthirion
left a comment
There was a problem hiding this comment.
Code LGTM. One minor comment on naming.
Contributor
|
Code LGTM but I haven't tested. Let me know if you'd like me to before merging. |
timthirion
approved these changes
Mar 15, 2021
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Oriented views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the views to better handle dataset orientation.