Skip to content

Conversation

@1isten
Copy link
Contributor

@1isten 1isten commented Mar 20, 2025

the ScalarProbe.vue causes console warning:
image

and causes this js error when switching Layout, for example from Quad View to Axial Only:
image
image

this PR fix above issues

@netlify
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c6128bd
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/67dbab05c8119e00083404a3
😎 Deploy Preview https://deploy-preview-722--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax
Copy link
Collaborator

PaulHax commented Mar 20, 2025

This is awesome, thank you so much for fixing my bugs. To get this mergred would you mind

  • Moving the undefined check for the missing sample.rep to the getBaseSlice() func? The base slice "sample" is basicly invalid if the ref is not defined yet, so better to catch that earler in the reactive chain.
  • Change the commit messages to follow semantic commit style. So change them to fix(ScalarProbe): eliminate vue console warning and fix(ScalarProbe): avoid accessing undefined rep
  • Be sure to format the code style so Pretter is happy: npm run prettify

@1isten
Copy link
Contributor Author

1isten commented Mar 20, 2025

Thanks @PaulHax , I created a new PR: #723, can you check?

@1isten 1isten closed this Mar 20, 2025
@1isten 1isten deleted the Fix_ScalarProbe branch March 21, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants