fix(server): Await web socket room entry#794
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
If you want to include the Python server deps changes you know works, that would be great. |
PaulHax
approved these changes
Oct 1, 2025
Could not install dependencies on `Darwin user 24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:53:27 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T6041 arm64` due to numpy build failure. Version bump has fixed the problem. ``` $ poetry install The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead. Updating dependencies Resolving dependencies... (3.7s) Package operations: 46 installs, 0 updates, 0 removals - Installing numpy (1.24.4): Failed PEP517 build of a dependency failed Backend 'setuptools.build_meta:__legacy__' is not available. Note: This error originates from the build backend, and is likely not a problem with poetry but one of the following issues with numpy (1.24.4) - not supporting PEP 517 builds - not specifying PEP 517 build requirements correctly - the build requirements are incompatible with your operating system or Python version - the build requirements are missing system dependencies (eg: compilers, libraries, headers). You can verify this by running pip wheel --no-cache-dir --use-pep517 "numpy (==1.24.4)". ```
Some of the io-bound functions in the rpc server are async and must be awaited. Co-authored-by: Forrest Li <forrest.li@kitware.com>
Collaborator
Author
I was able to resolve this with a minimal numpy upgrade to latest, let me know if things work with that. |
Collaborator
|
+1 Python floor at 3.11 is key =) Works for me tho "randon number triva" button fails probably because numbersapi.com is dead. I gave you permission to merge if you think this is ready |
arhowe00
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the io-bound functions in the rpc server are async and must be awaited.
Before:
VITE_REMOTE_SERVER_URLto.envAfter:
Note:
The deps for the python server might need to be upgraded but that's more trivial so I didn't push the changes I made to pyproject.toml as I wasn't sure if they were the right choices.