Conversation
Deploying bats-ai with
|
| Latest commit: |
defe1e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7e6bbf3.bats-ai.pages.dev |
| Branch Preview URL: | https://slope-storage-display.bats-ai.pages.dev |
| slope_avg_khz_per_ms: float | None | ||
| slope_hi_avg_khz_per_ms: float | None | ||
| slope_mid_avg_khz_per_ms: float | None | ||
| slope_at_hi_fc_knee_khz_per_ms: float | None | ||
| slope_at_fc_khz_per_ms: float | None | ||
| slope_at_low_fc_heel_khz_per_ms: float | None |
There was a problem hiding this comment.
Is this all of the slopes from batbot? I'm still not exactly sure which slopes they want. I know we talked about this at the meeting today, but I'm somewhat concerned that the requirement might change. In order to prevent data re-ingest, should we just store all of them in the database for now? We can change which ones/how we display them if requirements change
There was a problem hiding this comment.
I stored the six that it could be because the other ones seem like they are unlikely to be the slopes they want.
I'm asking Jason directly what he thinks it should be.
slope_at_hi_fc_knee_khz_per_ms: float | None = Field(None, alias="slope@hi fc:knee.khz/ms")
slope_at_fc_khz_per_ms: float | None = Field(None, alias="slope@fc.khz/ms")
slope_at_low_fc_heel_khz_per_ms: float | None = Field(None, alias="slope@low fc:heel.khz/ms")
slope_at_peak_khz_per_ms: float | None = Field(None, alias="slope@peak.khz/ms")
slope_avg_khz_per_ms: float | None = Field(None, alias="slope[avg].khz/ms")
slope_hi_avg_khz_per_ms: float | None = Field(None, alias="slope/hi[avg].khz/ms")
slope_mid_avg_khz_per_ms: float | None = Field(None, alias="slope/mid[avg].khz/ms")
slope_lo_avg_khz_per_ms: float | None = Field(None, alias="slope/lo[avg].khz/ms")
slope_box_khz_per_ms: float | None = Field(None, alias="slope[box].khz/ms")
slope_hi_box_khz_per_ms: float | None = Field(None, alias="slope/hi[box].khz/ms")
slope_mid_box_khz_per_ms: float | None = Field(None, alias="slope/mid[box].khz/ms")
slope_lo_box_khz_per_ms: float | None = Field(None, alias="slope/lo[box].khz/ms")
There was a problem hiding this comment.
Ok, yeah I think maybe slope_lo_avg_khz_per_ms might be relevant, although I'm not exactly sure what that means. Jason's input will be helpful
There was a problem hiding this comment.
I've updated and stored all values now
| <span | ||
| class="text-caption ml-4 text-medium-emphasis" | ||
| > | ||
| ({{ data.slopeAtHiFcKneeKhzPerMs.toFixed(2) }} kHz/ms) | ||
| </span> |
There was a problem hiding this comment.
I'm thinking we might want proper labels for the slopes. If the slope is average from x1 to x2, it could be like "Slope from Fmax to Knee". If its at a point, it could be "Slope at Knee"
There was a problem hiding this comment.
I'm going to wait until they see it and give me feedback, this is client side and can be changed easily.
resolves #389
Stores slopes calculations and displays them in the tooltip when hovered over a pulse: