Display track type in addition to name in events chart tooltip#1005
Merged
Display track type in addition to name in events chart tooltip#1005
Conversation
marySalvi
reviewed
Oct 21, 2021
Collaborator
marySalvi
left a comment
marySalvi
left a comment
There was a problem hiding this comment.
Looked over the code and ran locally. Looks good to me.
subdavis
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR threads an additional value, the track type, from
useEventChart()through to the event chart itself, showing it via the tooltip.The tooltip now displays something like
Track 0 (fish). In the future, we might want to make this more customizable, but as a static change for the moment, this seems like it adds useful information without hurting anything.Closes #1001.