Allow upload of DIVE json.#1014
Merged
Merged
Conversation
BryonLewis
previously approved these changes
Nov 1, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Fixes the issue so that track.json files are properly uploaded. Also extracted and uploaded configuration file and they seem to be working properly as well. Just one question about the is_dive_configuration function.
Comment on lines
+106
to
+110
| for key in [ | ||
| 'customTypeStyling', | ||
| 'confidenceFilters', | ||
| 'attributes', | ||
| ] |
Collaborator
There was a problem hiding this comment.
Just a question, could this use a Model Attribute instead of duplication of the fields? Popping version off the field keys and then doing an any? Would prevent duplicating the list in two places if more info is added in the future?
BryonLewis
approved these changes
Nov 2, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
pulled, built and tested again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1012
Adds new integration tests.