Dependency upgrades, Builder image downgrade.#1022
Merged
Conversation
subdavis
changed the title
waxlamp
approved these changes
Nov 3, 2021
BryonLewis
approved these changes
Nov 3, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
rebuilt the web version and tested.
Tested import, pipeline running, export and other stuff. Ran the full integration test suite as well.
Tested electron version and specifically the openDialog and other remote replacements as well as pipeline runnings and import of csv/json/config files.
Also tested building all of the versions to make sure builds all completed on my system with a fresh yarn install.
Everything seems to be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrade to NodeLTS for building, upgrade a lot of dev dependencies.
fixes #1021
replaces #987
@BryonLewis @marySalvi @waxlamp PSA: NodeJS active LTS changed to 16.3 last month https://nodejs.org/en/about/releases/ so 16.3 is now the sanctioned correct version for building DIVE (Once this PR merges)
you can use https://www.npmjs.com/package/n if you need to switch versions frequently.