Skip to content

Fix ffmpeg install#1031

Merged
subdavis merged 2 commits into
mainfrom
housekeeping/fix-ffmpeg-install
Nov 5, 2021
Merged

Fix ffmpeg install#1031
subdavis merged 2 commits into
mainfrom
housekeeping/fix-ffmpeg-install

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Nov 4, 2021

Tested with tox integration tests.

marySalvi
marySalvi previously approved these changes Nov 4, 2021
Copy link
Copy Markdown
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a fresh build and works as expected.

BryonLewis
BryonLewis previously approved these changes Nov 4, 2021
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a no-cache build with main to confirm the issue followed by one with this branch and it built properly.
Then did a series of uploads to the server that would require transcoding (image files, video files including AV1 video). Looks like all is good with this.

@subdavis subdavis dismissed stale reviews from BryonLewis and marySalvi via 3457bcf November 4, 2021 17:30
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled built and tested again. Specifically tested worker container reloading. Modified apipeline task to add some additional logging, ran ldc dev up girder_worker_pipelines and properly verified that it reloaded the container and displayed the new logging info. The existing stuff also seemed to work such as ffmpeg conversion and AV1 support.

@subdavis subdavis merged commit 8732e88 into main Nov 5, 2021
@subdavis subdavis deleted the housekeeping/fix-ffmpeg-install branch November 5, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ppa ffmpeg savoury1/ffmpeg4 broken

3 participants