Skip to content

Changes to docker-compose.yml to support maintenance#1035

Merged
subdavis merged 4 commits into
mainfrom
housekeeping/docker-compose-updates
Nov 9, 2021
Merged

Changes to docker-compose.yml to support maintenance#1035
subdavis merged 4 commits into
mainfrom
housekeeping/docker-compose-updates

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Nov 5, 2021

Summary of changes

  • Update .env.example to comment out unnecessary defaults duplicated in docker-compose
  • remove broken and unused worker compose file
  • remove duplicate rabbit override in dev file

@subdavis subdavis marked this pull request as ready for review November 9, 2021 14:08
@BryonLewis
Copy link
Copy Markdown
Collaborator

removal of the /docker/data folder from the build context in the .dockerignore, takes forever and really chews through RAM.

@subdavis subdavis force-pushed the housekeeping/docker-compose-updates branch 2 times, most recently from e698571 to 3b64f65 Compare November 9, 2021 17:50
@subdavis subdavis force-pushed the housekeeping/docker-compose-updates branch from 3b64f65 to 5170b44 Compare November 9, 2021 17:51
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some ongoing tests running but this was the only thing I ran into that might need to be changed.

Comment thread docker/.env.default
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got everything back up with volumes and did full testing+integration. Thanks for those changes and fixing the addons.

@subdavis subdavis merged commit 037f40f into main Nov 9, 2021
@subdavis subdavis deleted the housekeeping/docker-compose-updates branch November 9, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants