Virtual Type List#1036
Merged
Merged
Conversation
* Possible changes * Further refine type list
subdavis
suggested changes
Nov 15, 2021
Contributor
subdavis
left a comment
There was a problem hiding this comment.
One last thing I forgot.
subdavis
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1011
Use this command to generate data for comparison:
dive generate-data --video --frames 5000 --width 50 --height 50 --fps 30 --tracks 15000 --types 2000Not the biggest fan of using element Ids and calculating remaining space for sizing the virtual-scroll-list let me know of any better alternatives.
TypeItem.vueto contain the individual items in the virtual scroll list. Updated the passing of the entirecheckedTypeRefto only passing the current value for the specific check item.Future: