Skip to content

Virtual Type List#1036

Merged
BryonLewis merged 8 commits into
mainfrom
client/virtual-type-list
Nov 16, 2021
Merged

Virtual Type List#1036
BryonLewis merged 8 commits into
mainfrom
client/virtual-type-list

Conversation

@BryonLewis
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis commented Nov 8, 2021

fixes #1011

Use this command to generate data for comparison:
dive generate-data --video --frames 5000 --width 50 --height 50 --fps 30 --tracks 15000 --types 2000

Not the biggest fan of using element Ids and calculating remaining space for sizing the virtual-scroll-list let me know of any better alternatives.

  • Converts the typelist to utilize vuetify virtual scroll items instead of rendering them all
  • Speeds up filtering on large datasets significantly as well as bulk toggling and searching, and dragging the confidence slider.
  • Created TypeItem.vue to contain the individual items in the virtual scroll list. Updated the passing of the entire checkedTypeRef to only passing the current value for the specific check item.
  • Created a ResizeObserver I tied to the type list and the type-settings which will trigger when any size changes occur and use element Ids to calculate the remaining space to set the proper height of the virtual-scroll list. There are some checks in there to prevent it from setting heights when resizeObserver is triggered but the relevant height values are the same as well as throttle the setting during v-expand animations.
  • Typelist is given extra minimum height to account for the search bar now as well as provide a minimum height to show the scroll bar even when settings are open.

Future:

  • Decision on another issue/PR to improve detections timeline performance, it is now the limiter when sliding the confidence slider. Possibly throttling it at a higher interval could help?
  • Conversion of the confidence sliders to a virtual scroll list as well. It takes a little to load and edit items in that list and that could probably be sped up with another virtual scroll list

@BryonLewis BryonLewis marked this pull request as ready for review November 11, 2021 20:07
* Possible changes

* Further refine type list
Copy link
Copy Markdown
Contributor

@subdavis subdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing I forgot.

Comment thread client/src/components/TypeList.vue Outdated
@BryonLewis BryonLewis merged commit b361f20 into main Nov 16, 2021
@BryonLewis BryonLewis deleted the client/virtual-type-list branch November 16, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] TypeList virtual scroll list

2 participants