Add Data Format Documentation#1046
Merged
Merged
Conversation
BryonLewis
reviewed
Nov 15, 2021
Comment on lines
+15
to
+24
| ``` typescript | ||
| interface TrackData { | ||
| trackId: TrackId; | ||
| meta: StringKeyObject; | ||
| attributes: StringKeyObject; | ||
| confidencePairs: Array<ConfidencePair>; | ||
| features: Array<Feature>; | ||
| begin: number; | ||
| end: number; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this really helpful without defining what Feature and ConfidencePair are? I know you can go to the link below and the confidencePair/Feature definitions are right there. Confidence Pair I think can be simplified inline if required. Feature though is probably the important thing people care about if they make it to this page.
Contributor
Author
There was a problem hiding this comment.
I agree. Let's reproduce the other interfaces here.
BryonLewis
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems generally useful to have and will help both internal and external collaborators work with DIVE.