Add Documentation for Labels.txt#1092
Merged
Merged
Conversation
Merged
marySalvi
approved these changes
Dec 20, 2021
Collaborator
marySalvi
left a comment
marySalvi
left a comment
There was a problem hiding this comment.
LGTM. Thank you for investigating and clarifying the labels.txt file usage.
marySalvi
added a commit
that referenced
this pull request
Dec 20, 2021
* prelim work * add import of labels.txt to training menu * add labels.text as type and parameter * start work on adding labels.txt to viame run training * add labelText to desktop calls * update task for label_text * make labels command conditional on labels file existence * lint and tox * make labelText optional parameter * remove unnecessary TxtType and labelText values * make return for runTrainingOnFolder conditional and standardized async function * correct params order for labelText to be last and optional * send labelText as part of body of request * remove import button and openFromDisk method * remove incorrect test type * fix lint error and create pydantic class for training args * fix silly lint error * remove unnecessary txt typing * Add Documentation for Labels.txt (#1092) * WIP * Update Pipeline-Documentation.md Co-authored-by: Brandon Davis <brandon.davis@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some docs and added what I think are better labels and hints in the form.
If there are any issues here, I think they're on the viame side.