Skip to content

Fixes #733#1143

Merged
subdavis merged 4 commits into
mainfrom
server/bugfix-733
Feb 4, 2022
Merged

Fixes #733#1143
subdavis merged 4 commits into
mainfrom
server/bugfix-733

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Feb 1, 2022

fixes #733

Approach

  • Force reorder under the special condition that no tracks exist.
  • Handle errors when images don't exist

Testing

Dataset: https://viame.kitware.com/#/viewer/61f95585cf413d9ad2a200f5

CSV: output_tracks.csv

Try slight modifications to encounter error conditions (single track annotation, random image name)

@subdavis subdavis changed the title Fixes #733 for Web Fixes #733 Feb 2, 2022
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if CSV's occasionally have full/relative pathnames in the image sequence list if not you can ignore my python code change. Although it would make it more inline with what desktop does.

I think I only found one really really really stupid/weird corner case in which stuff could fail and am almost hesitant to mention it.

Good news is that it works properly with image lists being provided where the data is in multiple folders.

The weird failure case occurs in if you provide an image-list on desktop and one of the subfolders has an image the same name as another/parent folder. So you have 1 first.png and also 1_folder/1 first.png now all annotations will only show up on one of them. It properly duplicates the images and uses the sorting with the path names. I don't know what the proper solution is here.
Catch relative paths in CSV folder and Error out?
Use relative paths with the full paths to try to determine the proper image based on this?

Comment thread server/dive_utils/serializers/viame.py Outdated

if imageMap:
# validate image ordering if the imageMap is provided
imageName, _ = os.path.splitext(imageFile)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to os.path.basename(imageFile) first. I don't know these are typically generated from VIAME/View but the desktop version can handle paths being included in the filename specification and for upload we probably want to remove all C:/User/ or any /home/folder paths and rely on the root filename.

Copy link
Copy Markdown
Contributor Author

@subdavis subdavis Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: nevermind, I got it.

@subdavis subdavis merged commit 395b908 into main Feb 4, 2022
@subdavis subdavis deleted the server/bugfix-733 branch February 4, 2022 19:37
BryonLewis pushed a commit that referenced this pull request Feb 24, 2022
* Fixes #733

* Desktop support

* Unit test fix

* Respond to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When importing csvs for image sequences rely on filename first then ID

2 participants