Fixes #733#1143
Conversation
BryonLewis
left a comment
There was a problem hiding this comment.
I don't know if CSV's occasionally have full/relative pathnames in the image sequence list if not you can ignore my python code change. Although it would make it more inline with what desktop does.
I think I only found one really really really stupid/weird corner case in which stuff could fail and am almost hesitant to mention it.
Good news is that it works properly with image lists being provided where the data is in multiple folders.
The weird failure case occurs in if you provide an image-list on desktop and one of the subfolders has an image the same name as another/parent folder. So you have 1 first.png and also 1_folder/1 first.png now all annotations will only show up on one of them. It properly duplicates the images and uses the sorting with the path names. I don't know what the proper solution is here.
Catch relative paths in CSV folder and Error out?
Use relative paths with the full paths to try to determine the proper image based on this?
|
|
||
| if imageMap: | ||
| # validate image ordering if the imageMap is provided | ||
| imageName, _ = os.path.splitext(imageFile) |
There was a problem hiding this comment.
might want to os.path.basename(imageFile) first. I don't know these are typically generated from VIAME/View but the desktop version can handle paths being included in the filename specification and for upload we probably want to remove all C:/User/ or any /home/folder paths and rely on the root filename.
There was a problem hiding this comment.
edit: nevermind, I got it.
fdcdf69 to
837917e
Compare
fixes #733
Approach
Testing
Dataset: https://viame.kitware.com/#/viewer/61f95585cf413d9ad2a200f5
CSV: output_tracks.csv
Try slight modifications to encounter error conditions (single track annotation, random image name)