Fix Empty Image Filenames in CSV#1174
Merged
Merged
Conversation
subdavis
suggested changes
Feb 22, 2022
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
Nit: declare type named variable
| }); | ||
| parser.on('readable', () => { | ||
| let record: string[]; | ||
| let hasFilenames; |
Contributor
There was a problem hiding this comment.
This variable is named like a boolean variable, but it's not boolean. It's true/false/undefined. Please declare its type here so TS can enforce assignment.
subdavis
approved these changes
Feb 22, 2022
BryonLewis
added a commit
that referenced
this pull request
Feb 24, 2022
* Adding basics * Adding empty filename handling for CSV files * fix imageMap undefined issue * storing tests * adding in tests * adding type definition and fixing lint warning
subdavis
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Adding basics * Adding empty filename handling for CSV files * fix imageMap undefined issue * storing tests * adding in tests * adding type definition and fixing lint warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1173
Note: I wanted to add tests but the rejection process within the
viame.tsparsefunction wasn't working well using jest. I may need to look into this more to figure out how I can add some relevant tests for image ordering and this new error.