Add custom run pipeline settings support#1624
Merged
Louis-Pagnier-KW merged 6 commits intomainfrom Apr 24, 2026
Merged
Conversation
BryonLewis
requested changes
Apr 23, 2026
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
I haven't build a new container to test the web version or grabbed new pipelines for the desktop. Looks mostly good, just some question about typing and the icons.
BryonLewis
approved these changes
Apr 24, 2026
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
I'm good with this, nothing breaks if the underlying viame pipelines aren't updated and I could see some tooltips and other information on the electron version.
Thanks for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the following improvements to the run pipeline menu:
(The goal would be to limit the number of customizable settings, to not overload the UI).
Here are all possible values for parameters types:
Except for
path,fileandfoldertypes, which are only icons, there is form validation to ensure user inputs are valid.Currently, customizable parameters are specified in .pipe files using the
# DIVE_PARAMS["label", type, arg1, arg2, ...]comment suffix. There are current discussions on whether we should use dedicated files for this or not. However, changing how we read these metadata should not impact a lot of code of this PR.Note 1: Some work of this PR was already done by @mattdawkins on the viame/master branch:
Note 2: On the main branch of VIAME, this PR will have no effects.
To test the PR, you will have to compile VIAME web docker on the
dive-paramsbranch.