Skip to content

Add custom run pipeline settings support#1624

Merged
Louis-Pagnier-KW merged 6 commits intomainfrom
improve-run-pipeline-menu
Apr 24, 2026
Merged

Add custom run pipeline settings support#1624
Louis-Pagnier-KW merged 6 commits intomainfrom
improve-run-pipeline-menu

Conversation

@Louis-Pagnier-KW
Copy link
Copy Markdown
Collaborator

@Louis-Pagnier-KW Louis-Pagnier-KW commented Apr 21, 2026

This PR add the following improvements to the run pipeline menu:

  • Add description when cursor hover a pipeline (based on @mattdawkins work: viame/master)
  • Add pipeline input/output types when cursor hover a pipeline
  • Add a popup to override default pipeline parameters.
image image

(The goal would be to limit the number of customizable settings, to not overload the UI).

Here are all possible values for parameters types:

  • int
  • positive_int
  • strictly_positive_int
  • range_int
  • float
  • positive_float
  • strictly_positive_float
  • range_float
  • path
  • file
  • folder
  • string

Except for path, file and folder types, which are only icons, there is form validation to ensure user inputs are valid.

Currently, customizable parameters are specified in .pipe files using the # DIVE_PARAMS["label", type, arg1, arg2, ...] comment suffix. There are current discussions on whether we should use dedicated files for this or not. However, changing how we read these metadata should not impact a lot of code of this PR.

Note 1: Some work of this PR was already done by @mattdawkins on the viame/master branch:

  • Description overlay
  • Support for passing pipeline params to VIAME using "-s" arguments

Note 2: On the main branch of VIAME, this PR will have no effects.
To test the PR, you will have to compile VIAME web docker on the dive-params branch.

@Louis-Pagnier-KW Louis-Pagnier-KW self-assigned this Apr 21, 2026
@Louis-Pagnier-KW Louis-Pagnier-KW added Affects: Usability Related to interface usability or coherence Affects: VIAME Integration Affects: Desktop Related to DIVE Desktop Affects: Web Related to DIVE Web Type: Design python Pull requests that update Python code javascript Pull requests that update Javascript code labels Apr 21, 2026
@Louis-Pagnier-KW Louis-Pagnier-KW changed the title Draft: Add custom run pipeline settings support Add custom run pipeline settings support Apr 23, 2026
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't build a new container to test the web version or grabbed new pipelines for the desktop. Looks mostly good, just some question about typing and the icons.

Comment thread client/dive-common/components/RunPipelineToast.vue
Comment thread client/dive-common/components/PipelineParamsDialog.vue
@BryonLewis BryonLewis self-requested a review April 24, 2026 11:58
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, nothing breaks if the underlying viame pipelines aren't updated and I could see some tooltips and other information on the electron version.

Thanks for working on this.

@Louis-Pagnier-KW Louis-Pagnier-KW merged commit 6950ea0 into main Apr 24, 2026
4 checks passed
@Louis-Pagnier-KW Louis-Pagnier-KW deleted the improve-run-pipeline-menu branch April 24, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects: Desktop Related to DIVE Desktop Affects: Usability Related to interface usability or coherence Affects: VIAME Integration Affects: Web Related to DIVE Web javascript Pull requests that update Javascript code python Pull requests that update Python code Type: Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants