Skip to content

Add pan/zoom reset button#298

Merged
subdavis merged 5 commits intomasterfrom
client/reset-zoom
Aug 28, 2020
Merged

Add pan/zoom reset button#298
subdavis merged 5 commits intomasterfrom
client/reset-zoom

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Aug 21, 2020

  • Remove explicit column sizes in control bar.
  • add button with tooltip to reset zoom/pan of video, mostly helpful while annotating a polygon.

Wait for upstream to merge, blocked on #270

Screenshot from 2020-08-21 11-35-35

@subdavis subdavis changed the title Add center button Add pan/zoom reset button Aug 21, 2020
@subdavis subdavis changed the base branch from client/lib to master August 21, 2020 16:18
@subdavis subdavis marked this pull request as ready for review August 21, 2020 16:21
@subdavis
Copy link
Copy Markdown
Contributor Author

Realized I needed to add the option to the help menu, and I figured it'd be a good idea to style it as "flat" to match the rest of the app. While I was there, I fixed a bit of alignment.

Before

Screenshot from 2020-08-21 13-06-26

After

Screenshot from 2020-08-21 13-02-56

@subdavis subdavis requested a review from BryonLewis August 24, 2020 17:58
Comment thread client/app/components/UserGuideDialog.vue
Comment thread client/src/components/controls/Controls.vue
@subdavis
Copy link
Copy Markdown
Contributor Author

Fixed. Added index to key, added some min-width. Since app injects arbitrary-width controls into those slots, I made controls only aware of the play/skip width and constrained the window width to at least 700. Anything below 1200 is unusable to me, but we really shouldn't be attempting to support mobile-width layouts IMO.

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I also agree with the not supporting mobile. My intent wasn't to support mobile, just not get weird when making the window small, who knows why but given a public facing user base someone will try to utilize it in a narrow window.

@subdavis subdavis merged commit a30d810 into master Aug 28, 2020
@subdavis subdavis deleted the client/reset-zoom branch August 28, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants