Skip to content

Some suggestions#446

Merged
subdavis merged 1 commit into
client/attribute_uifrom
client/attribute_ui_suggestions
Nov 17, 2020
Merged

Some suggestions#446
subdavis merged 1 commit into
client/attribute_uifrom
client/attribute_ui_suggestions

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Nov 17, 2020

See actual changes in inline comments.

All this really does is

  • aligns the headers, fixes an alignment issue in icon pencil buttons
  • changes the background color because all the white lines are just noise to my eyes.
  • makes the headers more dense, vertical space is precious.

Also ran autoformatting.

Result

Screenshot from 2020-11-17 10-17-15

Comment thread client/viame-web-common/components/AttributesPanel.vue
Comment thread client/viame-web-common/components/AttributesPanel.vue
</v-btn>
</template>
<span>Edit ConfidencePairs</span>
</v-tooltip>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it was just a button that enabled another button.

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was that like the others it could toggle you into an edit mode that allowed you to edit the confidencePairs. It may make more sense to use the single item editing on click like with the other sections. So I'm good with this.

Comment thread client/viame-web-common/components/AttributesPanel.vue
Comment thread client/viame-web-common/components/AttributesPanel.vue
Comment thread client/viame-web-common/components/AttributesPanel.vue
@subdavis subdavis requested a review from BryonLewis November 17, 2020 15:22
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I really like the header styling now and was having difficulty adjusting it to something that made sense.

I think I still want to have a discussion on whether there should be 3 levels of viewing or only 2.
I mean should the process of adding new items that are in the attribute template be a separate view. I'm worried about cluttering the default view with too much unused attributes, but I understand how it could get confusing that transferring from a undefined value is similar to the area where you add in new attributes or remove them.

@subdavis subdavis merged commit cb98743 into client/attribute_ui Nov 17, 2020
@subdavis subdavis deleted the client/attribute_ui_suggestions branch November 17, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants