Skip to content

Format text custom function#489

Merged
subdavis merged 2 commits into
masterfrom
client/format-text
Dec 14, 2020
Merged

Format text custom function#489
subdavis merged 2 commits into
masterfrom
client/format-text

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis requested a review from BryonLewis December 11, 2020 20:28
@BryonLewis
Copy link
Copy Markdown
Collaborator

is this still too locked down? Should you be able to edit the styling at the same time if you want to edit the text? Text size, color and other options are still dependent on the type specified. I don't know the immediacy of this or the intended usage, but just wondering if we should give some more control besides just formatting the TextData output.

@subdavis
Copy link
Copy Markdown
Contributor Author

text size, color and other options are still dependent on the type specified

You'd have to "coordinate" with the typeStyling properties, which I think is reasonable given that's how everything else works.

This is already much more than Zach needs, so I'm reluctant to go out of my way to make this ultra-flexible without a use case. This was just the most convenient way to expose the functions he needed.

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing worked well.

I'm open to any ideas you may have about multiple text items per FrameDataTrack. I just don't want to have to break or change this functionality afterwards to solve a VIAME issue.

Comment thread client/src/layers/TextLayer.ts Outdated
@BryonLewis BryonLewis self-requested a review December 14, 2020 15:39
@subdavis subdavis merged commit 2b744c6 into master Dec 14, 2020
@subdavis subdavis deleted the client/format-text branch December 14, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants