Disable unit testing on windows for now#534
Merged
Merged
Conversation
BryonLewis
approved these changes
Jan 19, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
We can create an issue and assign it to me with getting the tests to pass on windows. I'm assuming using some os statements for the tests would work. Also looks like there are some npm packages for conditional testing among different operating systems.
Contributor
Author
|
It's just path matching. The solution is as simple as Edit, the above is a regular expression, not an emoji expression of my displeasure with windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows release to succeed. Can consider a more suitable fix later.