Desktop Using Trained Pipelines#550
Merged
Merged
Conversation
Contributor
|
Looks like u got some conflicts. |
subdavis
suggested changes
Feb 1, 2021
Contributor
subdavis
left a comment
There was a problem hiding this comment.
One minor thing. This looks great!
Comment on lines
+23
to
+33
| const trainedPipelines = computed(() => { | ||
| const list: string[] = []; | ||
| Object.entries(unsortedPipelines.value).forEach(([, category]) => { | ||
| category.pipes.forEach((pipe) => { | ||
| if (pipe.type === 'trained') { | ||
| list.push(pipe.name); | ||
| } | ||
| }); | ||
| }); | ||
| return list; | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| const trainedPipelines = computed(() => { | |
| const list: string[] = []; | |
| Object.entries(unsortedPipelines.value).forEach(([, category]) => { | |
| category.pipes.forEach((pipe) => { | |
| if (pipe.type === 'trained') { | |
| list.push(pipe.name); | |
| } | |
| }); | |
| }); | |
| return list; | |
| }); | |
| const trainedPipelines = computed(() => { | |
| return unsortedPipelines.value.trained || []; | |
| }); |
Untested, but doesn't this work? The pipes are already divided by category. You don't need to check their type, that's just a convenience of the schema.
Collaborator
Author
There was a problem hiding this comment.
Needs to be slightly changed because I'm using an includes on an array and trained is an Category which contains an array of Pipes. So it's either modify the includes to be a find or something else or modify the source. I've adjusted to simplify the computed property with TS guaranteeing that if trained exists then pipes is an array..
interface Pipe {
name: string;
pipe: string;
type: string;
}
interface Category {
description: string;
pipes: Pipe[];
}
subdavis
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline outputs follow the way the web is done with a
{type}.pipefile and a .zip file that are moved into a folder in the DIVE_Pipelines. This folder is spread onto the pipeline object with the category of 'trained' when the pipeline list is requested.[type].pipefile. Then it will move that into the DIVE_Pipelines directory.Question:
Note:
This has had the basic train_netharn_cascade.viame_csv.conf testing process done on it.
Future PRs:
train_netharn_cascade.viame_csv.confpipelines). This could be done in a few ways:.pipeand other data