Several smaller bugfixes#556
Merged
Merged
Conversation
Contributor
|
I spent a while messing with this, I couldn't find anything wrong with it. Looks like it solves all those issues. Thanks! |
subdavis
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #554 - adds quotations around inputs for running pipelines. It isn't an issue with ffmpeg. Isn't an issue with training either because of the manifest input files. Easy to replicate issue using a video file with spaces in the name.
fixes #541 - somewhere along the way we the exit condition for continuous mode change. We now allow the user to perform two clicks to create a rect or click and drag. I updated the documentation in the tool tip and checked the wiki but didn't see anything there. I also made it so continuous detection mode is disabled by default to prevent confusing users. The main issue was that single clicking wasn't getting users out of continuous mode.
fixes #477 - adding a trim feature when putting in type names. Before you could have a type name of ' '. Checked and this is already done for the attributes.
fixes #475 - this is the one that may have the most impact. The issue was that clicking from focus on a track input box back to the geoJS area would cause an update in the tracks and call
updateLayersin geoJS while you were in the middle of a annotation creation. This would disable the creation mode and then it would process the mouse click indicating that you are clicking on nothing and deselect the newly created track. I added in a check to see if you are in creation mode and the current annotation has no coordinates. This should prevent it from kicking out of creation mode and resetting the selected track when this happens. A standard Escape button will cancel just like before as well. I would test this one more thoroughly than the others.fixes #555 - some styling changes to the confidence pairs section for larger lists.