Skip to content

Several smaller bugfixes#556

Merged
BryonLewis merged 2 commits into
masterfrom
bugfixes
Feb 5, 2021
Merged

Several smaller bugfixes#556
BryonLewis merged 2 commits into
masterfrom
bugfixes

Conversation

@BryonLewis
Copy link
Copy Markdown
Collaborator

fixes #554 - adds quotations around inputs for running pipelines. It isn't an issue with ffmpeg. Isn't an issue with training either because of the manifest input files. Easy to replicate issue using a video file with spaces in the name.

fixes #541 - somewhere along the way we the exit condition for continuous mode change. We now allow the user to perform two clicks to create a rect or click and drag. I updated the documentation in the tool tip and checked the wiki but didn't see anything there. I also made it so continuous detection mode is disabled by default to prevent confusing users. The main issue was that single clicking wasn't getting users out of continuous mode.

fixes #477 - adding a trim feature when putting in type names. Before you could have a type name of ' '. Checked and this is already done for the attributes.

fixes #475 - this is the one that may have the most impact. The issue was that clicking from focus on a track input box back to the geoJS area would cause an update in the tracks and call updateLayers in geoJS while you were in the middle of a annotation creation. This would disable the creation mode and then it would process the mouse click indicating that you are clicking on nothing and deselect the newly created track. I added in a check to see if you are in creation mode and the current annotation has no coordinates. This should prevent it from kicking out of creation mode and resetting the selected track when this happens. A standard Escape button will cancel just like before as well. I would test this one more thoroughly than the others.

fixes #555 - some styling changes to the confidence pairs section for larger lists.

image

@BryonLewis BryonLewis requested a review from subdavis February 5, 2021 16:19
@subdavis
Copy link
Copy Markdown
Contributor

subdavis commented Feb 5, 2021

I spent a while messing with this, I couldn't find anything wrong with it.

Looks like it solves all those issues. Thanks!

@BryonLewis BryonLewis merged commit 8d949e6 into master Feb 5, 2021
@subdavis subdavis deleted the bugfixes branch February 12, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants