Add env to configure default viame path#565
Merged
Merged
Conversation
BryonLewis
reviewed
Feb 5, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
haven't pulled but won't this reset itself on each launch? Meaning you're locked into your env variable location and have to reset it each time you launch the app if you want to use a different version or something else. Should changing the install location reset the env variable?
Contributor
Author
I don't think so, but I'm not sure what you're asking. If a user sets their install path through the GUI, the default, and therefor the environment variable, will be totally ignored. Basically, the env var works up until the point where the user hits the settings save button, then it's ignored forever. |
BryonLewis
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
DIVE_VIAME_INSTALL_PATHon all platforms will override the platform default.If a user sets the value themselves on the settings page, the environment var will be ignored.
fixes #560