Skip to content

Creation mode switching bugfix#569

Merged
BryonLewis merged 2 commits into
masterfrom
bugfix-568
Feb 10, 2021
Merged

Creation mode switching bugfix#569
BryonLewis merged 2 commits into
masterfrom
bugfix-568

Conversation

@BryonLewis
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis commented Feb 8, 2021

More explicitly determines what changes will cause disabling the current editing process. Changes to the track type or other values shouldn't cause the in process annotation to disable and reset. Changes to the editType, selectedTrack or selectedKey will cause the editAnnotationLayer to disable and switch to a different mode.

I'm using the existing changeData stuff for line creation to skip updates when data not relevant to the current editing Type (line,rectnagle, poly) or selectedKey isn't changed. So if track types are changed it won't kick it out of editing mode.

I found another issue in here related to continuous head/tail mode that has to do with rectangleLayer selecting the previously created mode on mouse release right after creation causing the older trackId to be reselected instead of the new one.

@BryonLewis BryonLewis requested a review from subdavis February 8, 2021 18:40
@BryonLewis BryonLewis linked an issue Feb 8, 2021 that may be closed by this pull request
@subdavis
Copy link
Copy Markdown
Contributor

subdavis commented Feb 10, 2021

Sorry for the delay. I'm really trying to get my head back around how these parts of the code work again, beyond just what these small changes do.

@BryonLewis
Copy link
Copy Markdown
Collaborator Author

Sorry for the delay. I'm really trying to get my head back around how these parts of the code work again, beyond just what these small changes do.

I fully understand. It was hurting my head the other day even attempting to wrap my mind about the data flow during the annotation editing/creation process and how it can be interrupted by changing annotation Types, Track Types or other reactive changes that can cause a call to updateLayers inside of the LayerManager.

@BryonLewis BryonLewis merged commit 0fef61f into master Feb 10, 2021
@subdavis subdavis deleted the bugfix-568 branch February 12, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Regression] Creation controls are broken.

2 participants