Creation mode switching bugfix#569
Merged
Merged
Conversation
e900a8e to
b1092f9
Compare
Contributor
|
Sorry for the delay. I'm really trying to get my head back around how these parts of the code work again, beyond just what these small changes do. |
Collaborator
Author
I fully understand. It was hurting my head the other day even attempting to wrap my mind about the data flow during the annotation editing/creation process and how it can be interrupted by changing annotation Types, Track Types or other reactive changes that can cause a call to |
subdavis
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More explicitly determines what changes will cause disabling the current editing process. Changes to the track type or other values shouldn't cause the in process annotation to disable and reset. Changes to the editType, selectedTrack or selectedKey will cause the editAnnotationLayer to disable and switch to a different mode.
I'm using the existing changeData stuff for line creation to skip updates when data not relevant to the current editing Type (line,rectnagle, poly) or selectedKey isn't changed. So if track types are changed it won't kick it out of editing mode.
I found another issue in here related to continuous head/tail mode that has to do with rectangleLayer selecting the previously created mode on mouse release right after creation causing the older trackId to be reselected instead of the new one.