Skip to content

Fix #595 "View Console Log", Add scrolling, Launch Job Folder in file browser.#621

Merged
subdavis merged 5 commits into
mainfrom
client/fix-595
Mar 8, 2021
Merged

Fix #595 "View Console Log", Add scrolling, Launch Job Folder in file browser.#621
subdavis merged 5 commits into
mainfrom
client/fix-595

Conversation

@subdavis
Copy link
Copy Markdown
Contributor

@subdavis subdavis commented Mar 8, 2021

Screenshot from 2021-03-08 12-43-35

fixes #595
fixes #601

@subdavis subdavis requested a review from BryonLewis March 8, 2021 17:44
BryonLewis
BryonLewis previously approved these changes Mar 8, 2021
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just me being a pain. Could we possibily:
@click="visibleOutput = visibleOutput !== job.job.key ? job.job.key : null"
or something similar to be able to toggle close an open console, maybe a text change in the process as well.
I just know that I've subconsciously clicked again expecting it to work more like a vuetify expansion panel. Not a big deal if out of scope and obviously not necessary right now.

@subdavis
Copy link
Copy Markdown
Contributor Author

subdavis commented Mar 8, 2021

You should know by now that I can never just do one thing.

@subdavis subdavis changed the title Fix #595 "View Console Log" Fix #595 "View Console Log", Add scrolling, Launch Job Folder in file browser. Mar 8, 2021
@subdavis subdavis requested a review from BryonLewis March 8, 2021 21:51
BryonLewis
BryonLewis previously approved these changes Mar 8, 2021
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with whatever you decide for the styling of the 'file manager' button, I just noticed that it doesn't standout but it may not need to. Thanks for the button, it is much appreciated.

class="selectable"
@click="openPath(job.job)"
>
show in file manager
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally styled to be somewhat hidden? It doesn't look like a clickable area like the Console Log it's regular text that has a cover state.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

Screenshot from 2021-03-08 17-40-23

@subdavis subdavis merged commit 6e8e3e2 into main Mar 8, 2021
@subdavis subdavis deleted the client/fix-595 branch March 8, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add scroll bar on view console output in jobs panel [FEATURE] "View Output" on Jobs panel is ambigious

2 participants