Compensate for Chromium MPEG inaccuracy.#627
Merged
Merged
Conversation
BryonLewis
previously approved these changes
Mar 9, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Sorry it took me so long to conceptualize what was going on.
Contributor
Author
|
Updated to reflect the true cause of this bug: Chrome! See detailed inline comment about how and why this fix is correct. |
subdavis
changed the title
BryonLewis
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was exactly what I expected: falling on the wrong side of the frame boundary due to small variations in real frame size and maybe floating point errors.
Also force video playback pause events to snap to nearest frame boundary so that detections created on video that was paused cannot happen in the middle of a frame's width.
fixes #610