-
Notifications
You must be signed in to change notification settings - Fork 24
upgrade gwc to 3.0.1 #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
upgrade gwc to 3.0.1 #643
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56b68af
upgrade gwc to 3.0.0
subdavis 0727c17
3.0.1
subdavis 76228ed
Things
subdavis 814c68f
Merge in plugin
subdavis 22105d0
Fix imports
subdavis ff7a96d
Check in missing files
subdavis 64af61a
Merge branch 'main' into gwc/update
subdavis db5a95b
Remove vtk, other tweaks
subdavis 3fc19f2
Merge branch 'gwc/update' of github.com:Kitware/dive into gwc/update
subdavis 5b39270
Fix lockfile
subdavis 940d37e
Merge branch 'main' into gwc/update
BryonLewis a8a9101
Repond to comments
subdavis 09caa5d
Merge branch 'main' into gwc/update
subdavis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,11 @@ | ||
| import Vue from 'vue'; | ||
| import NotificationBus from '@girder/components/src/utils/notifications'; | ||
| import Girder, { RestClient } from '@girder/components/src'; | ||
|
|
||
| Vue.use(Girder); | ||
| const girderRest = new RestClient({ apiRoot: 'api/v1' }); | ||
| export const notificationBus = new NotificationBus(girderRest); | ||
|
|
||
| export function useGirderRest() { | ||
| return girderRest; | ||
| } | ||
|
|
||
| export function useNotificationBus() { | ||
| return notificationBus; | ||
| } | ||
|
|
||
| export default girderRest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rely on the
loginsignal from therestClientto connect instead of doing it here?If you sit at the login screen it is constantly attempting to reconnect right now because there is a 401 error so it's in the error/reconnect loop. I could be missing something though.