Skip to content

Web Stereoscopic Support#730

Merged
BryonLewis merged 16 commits intomainfrom
web/stereoscopic-support
May 13, 2021
Merged

Web Stereoscopic Support#730
BryonLewis merged 16 commits intomainfrom
web/stereoscopic-support

Conversation

@BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented May 3, 2021

Started working on a web version of the stereoscopic and that is going to require some changes to the upload of data. At the very least we needed a way to add the multicam dialogs to the web version.

Tasks Completed:

  • Converted openFromDisk to be used in both web and Desktop.
  • Moved types for import files to dive-common as well so they can be used while importing data for file filtering
  • Created a openFromDisk in viame.service.ts Added filetype filtering to the open dialog that should work properly.
  • Moved a bunch of shared datatypes and components to dive-common from the desktop (mostly that deal with multiCam). Stuff like the constants for file types, the MultiCamInputArgs, and a shared sense of openFromDisk so that the shared multicam args can be used across both.
  • Removed girder dropzone to replace it with the import buttons
  • Moved ImportButton and ImportMultiCamDialog to dive-common where both web and desktop can use their functionality.
  • Updated pendingUpload to display the media files, annotation file and meta file individually as well as allow the user to edit it. Metadata files are currently hidden until they are supported as well as multi-cam/stereo
  • Refactored the mixin stuff into GirderUpload.vue component into a subset of Upload so I could switch Upload.vue into a typescript component. Upload.vue manages file opening and organization as well as display of progress, the GirderUpload.vue handles all mixin aspects of uploading to Girder.

@BryonLewis
Copy link
Collaborator Author

@subdavis - just looking for initial impresses and if I am on the proper track. It's a prerequisite to get stereo data uploaded into web to be able to use it anyway.

rightTrackUploadsmall.mp4

@subdavis
Copy link
Contributor

subdavis commented May 3, 2021

I drew this while we were talking earlier just as the thing I had in my head. I'll read through and watch the video when my meetings are over. Thanks for the write-up.

IMG_0371 (2)

@BryonLewis
Copy link
Collaborator Author

I like that mock-up and will probably change stuff to look a bit more like that.

@subdavis
Copy link
Contributor

subdavis commented May 3, 2021

You don't need to change anything yet. We can make a second pass later if what you have now is a good first pass.

@BryonLewis BryonLewis marked this pull request as ready for review May 10, 2021 13:54
@BryonLewis BryonLewis requested a review from subdavis May 13, 2021 13:04
Copy link
Contributor

@subdavis subdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

🚢 🇮🇹

@BryonLewis BryonLewis merged commit 9b5d90c into main May 13, 2021
@BryonLewis BryonLewis deleted the web/stereoscopic-support branch May 13, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants