Conversation
subdavis
previously approved these changes
May 28, 2021
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
tested on one and multiple datasets on desktop.
✔️ Generic SVM works
❌ SVM Over fish detectoins fails for the same old reason, looks like it was not updated.
subdavis
suggested changes
May 28, 2021
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
- Train detector default: runs, but took too long so I killed it. Result untestable
- Train detector netharn cfrnn motion: limited timeout, then ran. Result also ran.
- Train SVM over fish: ran, result also ran
- Train Frame classifier svm resnet: ran. result also ran.
- Train Netharn Object Classifer Nesnet: ran, result not available because zip file name is different. Should include
trained_classifier.zip. Can we just make that regex include "any pipe plus any zipfile"? Why does it need to match that closely? - Utilities 1 fr: ran
Looks like everything is in good shape except for that one thing.
subdavis
approved these changes
May 28, 2021
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
Now all my pipelines are discovered.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a relatively minor fix tor the desktop SVM support. It now ensures that there is at least a .pipe and a .svm file in there before adding it to the trained pipelines.
I double checked and it looks like the server version doesn't require any checking before placing the pipeline in the user's folder.