Calculate Max N for all classes for multiple datasets#783
Merged
Conversation
Member
+1 Didn't mentally parse the part about buttons but any quick first pass LGTM |
BryonLewis
previously approved these changes
May 29, 2021
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
I think just the one question about structure of the call to viame_summary, it's not vital and you can use your judgement as to if you want to move it into summary.service.ts
I went through and tested it on 4-5 copies of JRS8/7 and seemed really quick.
I used a smaller SeaLion dataset and verified the numbers and detection counts using the detection timeline viewer.
BryonLewis
approved these changes
May 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something to note: In order to make this fast, the actual detections (features) are not parsed, and instead the track bounds are used. That means that a track that spans 10 frames but that has no detection on a given frame will be counted in the summary for that frame. I believe this is correct from a stasticical perspective: the target is occluded, but exists in the frame.
If this is an incorrect way to count, the summary generator will need to be moved into a worker process and this will add some complexity.
I want to make the summary button it's own dialog with other report types, but this was the quick version. I added some icons to the button to indicate which ones had "submenus" but I could revert this if you want. Until now, all those buttons were "safe" -- they didn't do anything until you confirmed something in another menu. This button immediately generates a report, which could make the user hesitant to explore buttons.
Fixes #710