Skip to content

Calculate Max N for all classes for multiple datasets#783

Merged
subdavis merged 3 commits intomainfrom
server/summary-counts
May 29, 2021
Merged

Calculate Max N for all classes for multiple datasets#783
subdavis merged 3 commits intomainfrom
server/summary-counts

Conversation

@subdavis
Copy link
Contributor

@subdavis subdavis commented May 28, 2021

Screenshot from 2021-05-29 14-47-02

Something to note: In order to make this fast, the actual detections (features) are not parsed, and instead the track bounds are used. That means that a track that spans 10 frames but that has no detection on a given frame will be counted in the summary for that frame. I believe this is correct from a stasticical perspective: the target is occluded, but exists in the frame.

If this is an incorrect way to count, the summary generator will need to be moved into a worker process and this will add some complexity.

I want to make the summary button it's own dialog with other report types, but this was the quick version. I added some icons to the button to indicate which ones had "submenus" but I could revert this if you want. Until now, all those buttons were "safe" -- they didn't do anything until you confirmed something in another menu. This button immediately generates a report, which could make the user hesitant to explore buttons.

Fixes #710

@subdavis subdavis marked this pull request as ready for review May 29, 2021 18:46
@mattdawkins
Copy link
Member

I believe this is correct from a stasticical perspective: the target is occluded, but exists in the frame.
I want to make the summary button it's own dialog with other report types, but this was the quick version.

+1

Didn't mentally parse the part about buttons but any quick first pass LGTM

BryonLewis
BryonLewis previously approved these changes May 29, 2021
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the one question about structure of the call to viame_summary, it's not vital and you can use your judgement as to if you want to move it into summary.service.ts

I went through and tested it on 4-5 copies of JRS8/7 and seemed really quick.
I used a smaller SeaLion dataset and verified the numbers and detection counts using the detection timeline viewer.

@subdavis subdavis merged commit e593e07 into main May 29, 2021
@subdavis subdavis deleted the server/summary-counts branch May 30, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Cross-video analytics output into a single summary csv

3 participants