Skip to content

Added population counters for selected types#797

Merged
f4str merged 2 commits intomainfrom
client/population-counters-645
Jun 9, 2021
Merged

Added population counters for selected types#797
f4str merged 2 commits intomainfrom
client/population-counters-645

Conversation

@f4str
Copy link

@f4str f4str commented Jun 4, 2021

fixes #645

Displays counter in parentheses next to selected type. Literal count of all tracks in track list grouped by type. When the type is unchecked, the counter disappears. Counter updates automatically as the confidence filter slider is changed.
image

Still need some tests on performance and efficiency.

@f4str f4str requested review from BryonLewis and subdavis June 4, 2021 21:05
@f4str f4str marked this pull request as ready for review June 7, 2021 17:18
Copy link
Contributor

@subdavis subdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove unnecessary null check
  • Maybe try lodash groupby for an even more concise implementation.

@subdavis
Copy link
Contributor

subdavis commented Jun 7, 2021

BTW, nice job figuring out how all this stuff works. track.getType and the context and stuff.

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's tight on space in that location, but I'm wondering if we can standardize the location of the count number. I don't know if at the front is the best or if a new 'column' to the right works better? Just so it's easier to scroll down and take a quick look at counts easily.

@subdavis
Copy link
Contributor

subdavis commented Jun 8, 2021

Flexbox spacer, maybe?

@subdavis
Copy link
Contributor

subdavis commented Jun 8, 2021

@f4str pointed out that the edit button is already in that space. Let's try it like this first?

@BryonLewis
Copy link
Collaborator

@f4str pointed out that the edit button is already in that space. Let's try it like this first?

Yeah I knew the edit button was there that's why I was saying we were tight for space as is. I'm good with trying it as is.

@f4str
Copy link
Author

f4str commented Jun 8, 2021

Another thing we can try is aligning the count right underneath the gear. The edit button is aligned right underneath the delete button. However, I think it looks kind of weird having a number floating on the right like that. I think we should try as is with the parentheses next to the name, but I'm open to any other suggestion.

@f4str f4str requested review from BryonLewis and subdavis June 8, 2021 18:17
@f4str f4str merged commit 0d5d888 into main Jun 9, 2021
@f4str f4str deleted the client/population-counters-645 branch June 9, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add population counters

3 participants

Comments