Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #808
Quick fix for the resizeObserver Error. My understanding is that this is an error in chrome/firefox that isn't typically logged but can be shown if you subscribe to all errors on the window object :
window.onerror = (e) => console.log(e)that should show it.It looks like it is a true infinite call error that the browser handles gracefully so that is why it isn't shown in console.log by default. The act of resizing the geoJS area during a resize event creates I think a cascading call to resize which the browser interprets and handles. Throwing a
requestAnimationFramearound it will delay the setting and hopefully prevent recursive updates.You can test it by using the console.log for the window.onerror and loading data and resizing the window while monitoring the console window. Without the animation frame request you'll get the error. I need to test for other instances where this may occur.
Some background support: