Conversation
subdavis
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
server/setup.pyto removeinclude_package_data=True. Although, it is used by other projects in girder, since this project does not useMANIFEST.infile, this option should not be used. This option does not matter since it is being deployed using docker, but if the Python project were to ever be published to pypa using bdist, this would cause issuesAs discussed, changed the
versioninserver/setup.pyto 1.0.0 since this will not be updated and should be kept at a consistent number.Fixed the
packages=find_packagesinserver/setup.pyto include the correct directory names.Changed the license field in
server/setup.pyto the correct Apache license name and updated the classifiers inserver/setup.pyto include all valid Python versions. This is what is used by other projects in girder.Added the license field in
client/package.jsonso yarn stops complaining.