Skip to content

Fixes #903 Import annotation error handling#910

Merged
subdavis merged 2 commits intomainfrom
bugfix/import-failures
Aug 31, 2021
Merged

Fixes #903 Import annotation error handling#910
subdavis merged 2 commits intomainfrom
bugfix/import-failures

Conversation

@subdavis
Copy link
Contributor

fixes #903

Until now, apparently the client would let you upload whatever json you wanted and postprocess would tag it as an annotation file without checking the formatting. Now, it's forced through a pydantic schema validation same as if you save.

Also fixes a bug where api.importAnnotationFile was not updated to use the new postprocessing endpoint.

@subdavis subdavis requested a review from BryonLewis August 30, 2021 20:38
@subdavis subdavis changed the title Fixes #903 Fixes #903 Import annotation error handling Aug 30, 2021
@subdavis subdavis requested a review from marySalvi August 30, 2021 20:45
* updates to import fix

* fix typing
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@subdavis subdavis merged commit 39ed08a into main Aug 31, 2021
@subdavis subdavis deleted the bugfix/import-failures branch August 31, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Import Annotations Button has no error handling

2 participants