Skip to content

fix(ParentedView): switch interactor on capture #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(ParentedView): switch interactor on capture #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions src/core/internal/ParentedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,9 @@ const ParentedView = forwardRef(function ParentedView(
const rendererAPI = rendererRef.current;
if (!rendererAPI) return false;

const interactor = getInteractor();
const interactor = getInteractor() as FixedVTKRenderWindowInteractor;

(interactor as FixedVTKRenderWindowInteractor).setCurrentRenderer(
rendererAPI.get()
);
interactor.setCurrentRenderer(rendererAPI.get());
interactor.setInteractorStyle(getInteractorStyle());

const oldContainer = interactor.getContainer();
Expand All @@ -108,21 +106,23 @@ const ParentedView = forwardRef(function ParentedView(

// Use wheel events to cover the posibility of interacting
// with an out-of-focus browser window.
useEventListener(containerRef, 'wheel', (ev: WheelEvent) => {
if (switchTarget()) {
// forward wheel-event to interactor
const interactor = getInteractor();
interactor.handleWheel(ev);
}
});
useEventListener(
containerRef,
'wheel',
() => {
switchTarget();
},
{ capture: true }
);

useEventListener(containerRef, 'pointerenter', (ev: PointerEvent) => {
if (switchTarget()) {
// forward pointer-event to interactor
const interactor = getInteractor();
interactor.handlePointerEnter(ev);
}
});
useEventListener(
containerRef,
'pointerenter',
() => {
switchTarget();
},
{ capture: true }
);

// --- resize handling --- //

Expand Down
1 change: 1 addition & 0 deletions src/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ declare module '@kitware/vtk.js/type-patches' {
export interface FixedVTKRenderWindowInteractor
extends vtkRenderWindowInteractor {
setCurrentRenderer(ren: vtkRenderer): void;
setContainer(el: HTMLElement | null): boolean;
}

export interface VtkRendererEvent {
Expand Down