-
Notifications
You must be signed in to change notification settings - Fork 24
Update react-vtk-js to v2 #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Working PolyData + GeometryRepresentation pipeline - Working Algorithm + GeometryRepresentation pipeline
This brings in the automatic JSX runtime for react 17+.
The externals key is wrong, and so a lot of external dependencies were being brought into the build output (e.g. vtk.js, react/jsx-runtime, etc.) This fixes the geometry representation mapper.modified() hack, which was needed when testing the Algorithm component in `usage` because there were two different globalMTime variables: one in the macros.js in dist/node_modules/@kitware/vtk.js, and another one in the usage/node_modules/... dir.
This avoids an infinite useEffect/setState loop via the modified flag.
Leaving IDownstream as a function is confusing and inconsistent.
The deletion registry manages the lifetime and tracking of registered objects.
These will be more useful when using a non-mounted canvas as the drawing source.
Add onViewReadySuspense hook
PET-CT fusion/overlay
Add MIP rendering of PET data
Upgrade PT/CT overlay example to generalize detection and handling of PT-CT grid overlap
feat: add color + opacity funcs to slice + volume
fix(useColorAndOpacity): set as null
🔧 MA-34 Fix Reader TSX
…ct-overlay-example feat(example): PET MIP with window/level adjustment
Support user defined color map preset
fix(Picking): guard against unmounted state
Update beta with master
update beta branch
Collaborator
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports:
Fixes:
Breaking changes:
FYI @jadh4v @sankhesh