fix: don’t attempt to call prop.get() when prop is nullish #25
Conversation
| const { prop, compositeID, displayPosition } = v.getProperties(); | ||
|
|
||
| // Return false to mark this item for removal | ||
| if (prop == null) return false; |
There was a problem hiding this comment.
Should we write if (!prop) { return false; } instead?
There was a problem hiding this comment.
I'm used to == null because it's the quickest way to check for null and undefined while not checking for any other falsy value, I know in this case it will always be either an object-type or null/undefined so it's not strictly needed, i't just clearer to me. (I come from a strict Flow-type checking background, sorry 😬)
| this.selections.forEach((v) => { | ||
| const { prop } = v.getProperties(); | ||
| const { representationId } = prop.get('representationId'); | ||
| const representationId = prop?.get('representationId').representationId; |
There was a problem hiding this comment.
I'm not sure if your build pipeline supports the optional chaining operator, I can replace it with something else if not.
There was a problem hiding this comment.
It is, I just checked the dist output.
|
Thanks, does that solve your issue? Can you rename your commit like |
Yes it works indeed |
|
Thanks for your contribution! |
|
🎉 This PR is included in version 1.5.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
fixes #24