feat(View): pointerSize property

[FezVrasta]

I'm trying to understand why these changes aren't working, as soon I set a pointerSize larger than 0 picking stops working 🤔

[jourdain]

Make sure the xy are ints.

[FezVrasta]

No luck :-(

[jourdain]

What are the symptoms of the issue?

[FezVrasta]

No selection happens at all.

[jourdain]

Be aware that by changing x1/x2 to be different you will always get a frustrum rather than a ray.

You may need to fix/extend the pick method to still perform the ray. Maybe by adding a bool arg for isFrustrum.

[FezVrasta]

Sorry I think I don't have enough knowledge on the matter to be helpful here :-(

[jourdain]

 pick(x1, y1, x2, y2, useFrustrum=false) {
      [...]
      if (useFrustrum) { // if (x1 !== x2 || y1 !== y2) {
      [...]
      const ray = [
        Array.from(
          this.openglRenderWindow.displayToWorld(Math.round((x1+x2) / 2), Math.round((y1+y2) / 2), 0, this.renderer)
        ),
        Array.from(
          this.openglRenderWindow.displayToWorld(Math.round((x1+x2) / 2), Math.round((y1+y2) / 2), 1, this.renderer)
        ),
      ];
      [...]

select => useFrustrum=true
click => useFrustrum=false
hover => useFrustrum=false

[jourdain]

Same code as before except the condition to detect if it is a click/hover=ray vs select=frustum is not based on the fact that x1 != x2. Otherwise you are changing the behavior of the selection.

[FezVrasta]

Thanks, it works now 👍

[jourdain]

You still need to fix the ray so it is at the center of the x1/x2/y1/y2 and not on one of the corner of the area.

[jourdain]

See my code snippet vs original

[jourdain]

All working? Ready to merge?

[FezVrasta]

For some reason with the ray change it seems to be not centered. Only the lower area is sensitive.

[jourdain]

The ray/frustum part are only info metadata and don't affect selection. Maybe the returned array from hover is bigger than 1 and you always pick the first one? Check what the selection returned array looks like?

[FezVrasta]

I think it's just an optical effect due to the pointer shape, I enlarged the pointer area and it actually looks good 😇

[jourdain]

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀